Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the Saturation components #1349

Open
ulfaslak opened this issue Jan 6, 2025 · 1 comment
Open

Rename the Saturation components #1349

ulfaslak opened this issue Jan 6, 2025 · 1 comment
Labels
media transforms Related to adstock, saturation, and media transformations MMM request discussion

Comments

@ulfaslak
Copy link
Contributor

ulfaslak commented Jan 6, 2025

I suggest we rename the saturation components (inside mmm.components.saturation) from ...Saturation... to ...Response....

As I see it:

$$\texttt{Response} = \texttt{beta} \times \texttt{Saturated-Driver}$$

So really, these components model the RESPONSE not just the saturation.
@ulfaslak ulfaslak added media transforms Related to adstock, saturation, and media transformations and removed Needs Triage labels Jan 6, 2025
@ulfaslak ulfaslak mentioned this issue Jan 6, 2025
Open
@wd60622 wd60622 added the MMM label Jan 6, 2025
@wd60622
Copy link
Contributor

wd60622 commented Jan 7, 2025

What about making all saturation transformations into saturation transformations. What is the case for that? The beta could be multiplied out else where and only when the full transformation takes place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
media transforms Related to adstock, saturation, and media transformations MMM request discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ulfaslak @wd60622