Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert TanhSaturation changes #1351

Open
wd60622 opened this issue Jan 7, 2025 · 0 comments
Open

Revert TanhSaturation changes #1351

wd60622 opened this issue Jan 7, 2025 · 0 comments
Labels
media transforms Related to adstock, saturation, and media transformations MMM

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jan 7, 2025 •
edited
Loading

Leave the general case as the specific case can be specified with constant priors

This would undo the removal of beta in the TanhSaturation class which happened in this PR: #1303

Cc @ulfaslak
@wd60622 wd60622 added media transforms Related to adstock, saturation, and media transformations MMM labels Jan 7, 2025
@wd60622 wd60622 changed the title Revert tanh saturation changes Revert TanhSaturation changes Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
media transforms Related to adstock, saturation, and media transformations MMM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wd60622