Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading documentation for CIBW_BEFORE_ALL #1685

Closed
doronz88 opened this issue Nov 30, 2023 · 6 comments
Closed

Misleading documentation for CIBW_BEFORE_ALL #1685

doronz88 opened this issue Nov 30, 2023 · 6 comments

Comments

@doronz88
Copy link
Contributor

Description

I'm trying to use cibuildwheel locally to test stuff before using the GitHub actions.
I an installation prequisite of libssl-dev and followed the guidelines from:
https://cibuildwheel.readthedocs.io/en/stable/setup/

However, when I try exporting CIBW_BEFORE_ALL to use apt just as the example suggests, I'm getting an error that no apt binary exists.

Build log

No response

CI config

No response

@joerick
Copy link
Contributor

joerick commented Nov 30, 2023

Which build fails? Link a build log. What's your exact config? etc.

@doronz88
Copy link
Contributor Author

Just discovered the real culprit - the documentation!
I got by the solution suggested in #1034 - I had to try and install using all package manager variations.
The documentation should be updated to reflect this is necessary.

@doronz88 doronz88 changed the title Failing to use apt using CIBW_BEFORE_ALL (followed documentation) Misleading documentation for CIBW_BEFORE_ALL Nov 30, 2023
@Czaki
Copy link
Contributor

Czaki commented Nov 30, 2023

The source of the problem is that not all docker images are debian based.
I think that this artifact from the time when manylinux temporarily switched to debian based. But currently, all things are almalinux (RedHat) and Alipne (muslinux) which both have their own installers and package names.

@doronz88
Copy link
Contributor Author

I get that, but I believe the documentation should state that it is built on several linux distros with different package managers. Usually, I expect documentation examples to work as-is.

@joerick
Copy link
Contributor

joerick commented Nov 30, 2023

ah, yeah that isn't a good snippet to include so early in the docs, and it is outdated given that the default image is now almalinux-based.

The point of this snippet is to show how to pass options to cibuildwheel. So we should change it to something less platform-dependent. CIBW_BUILD_FRONTEND=build could be a non-controversial replacement that works everywhere.

PR would be welcome for this!

@doronz88
Copy link
Contributor Author

Updated my PR for that #1686

@joerick joerick closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants