From 1197486fc0a7d2f35431ffa66f0d6cfd986cb651 Mon Sep 17 00:00:00 2001 From: Richard Si Date: Sun, 26 Jan 2025 18:44:42 -0500 Subject: [PATCH] ci: Test packaging flow on Windows Most of pip's maintainers use non-Windows environments, so it's easy for our tooling to regress on Windows. Let's avoid that for our release flow. In addition, remove the dependency on the packaging job by the test jobs. The packaging job rarely fails so we aren't saving any CI resources by failing early if the packaging job fails. --- .github/workflows/ci.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fa6dea0f30e..0db0f13a091 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -63,8 +63,11 @@ jobs: if: github.event_name == 'pull_request' packaging: - name: packaging - runs-on: ubuntu-22.04 + name: packaging (${{ matrix.os }}) + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-22.04, windows-latest] steps: - uses: actions/checkout@v4 @@ -104,7 +107,7 @@ jobs: name: tests / ${{ matrix.python.key || matrix.python }} / ${{ matrix.os }} runs-on: ${{ matrix.os }} - needs: [packaging, determine-changes] + needs: [determine-changes] if: >- needs.determine-changes.outputs.tests == 'true' || github.event_name != 'pull_request'