Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown renderer does not render GFM alerts #318

Open
nfelt14 opened this issue Aug 30, 2024 · 6 comments
Open

Markdown renderer does not render GFM alerts #318

nfelt14 opened this issue Aug 30, 2024 · 6 comments

Comments

@nfelt14
Copy link

nfelt14 commented Aug 30, 2024

The alerts that display on the main page of the repository are not displaying properly on PyPI

GitHub: https://github.com/tektronix/tm_devices
PyPI: https://pypi.org/project/tm-devices/

@di di changed the title PyPI does not render GFM alerts Markdown renderer does not render GFM alerts Aug 30, 2024
@di
Copy link
Member

di commented Aug 30, 2024

More context here: https://github.com/orgs/community/discussions/16925

@miketheman
Copy link
Member

I haven't seen these be added to the GFM spec yet.

@di
Copy link
Member

di commented Aug 30, 2024

Version 0.29-gfm (2019-04-06)

Not sure if we'll see it happen...

@miketheman
Copy link
Member

FWIW, they do update their code without necessarily updating the spec, and we're on the latest release: https://github.com/github/cmark-gfm/releases/tag/0.29.0.gfm.13

@nfelt14
Copy link
Author

nfelt14 commented Aug 30, 2024

FWIW, they do update their code without necessarily updating the spec, and we're on the latest release: https://github.com/github/cmark-gfm/releases/tag/0.29.0.gfm.13

I kind of thought it was something like this, unfortunately.

@flying-sheep
Copy link

According to @wooorm, this stuff will never be part of the spec, because it’s a GitHub postprocessing feature and not a syntax feature (source: github/cmark-gfm#350)

Since most of the the other postprocessing stuff is GitHub specific (like linking PRs and so on), I doubt it’s in scope to implement it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants