-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module build error when build directory path contains a ":" #1083
Comments
the build invocation looks incorrect as its not using isolation, it may be necessary to add the necessary pythonpath entries to support build https://github.com/pypa/setuptools-scm/blob/main/pyproject.toml#L9-L12 is supposed to ensure the backend can be imported if it cant be found, path handling in the build tool is wrong |
Certainly it's not a path handling error in the build tool as it's a python error, but I'm working on fixing it by editing the toml file downstream in the recipe build file as you suggested. |
@RonnyPfannschmidt the issue seems to be that the path gets split at the EDIT: no sorry again it's at the ':'. |
ok so i think the reason setting the pythonpath variable does not work is pyproject-hooks [opens]( a new python in a subprocess. https://github.com/pypa/pyproject-hooks/blob/main/src/pyproject_hooks/_impl.py#L392-L396 |
@RonnyPfannschmidt ok so the issue is at As usual Microsoft, Windows and NTFS create issues even when they are not used. |
Okay so I've opened a related pyprojects-hooks issue and published a partial fix in a new minor release (v1.2.1) on the martian company namespace for the project. |
Please create a upstream pull request as well |
Ps colons are path separators only on unix Windows uses semicolon and isn't affected |
@RonnyPfannschmidt I am sorry but I've not opened a merge request upstream because I've just added code to report at failure one should not use the semicolons in the path. |
I'm not sure if I have already opened this issue yesterday but it seems the module does not build if the build path contains a
:
.It may be a pyproject-hooks issue, I've not really checked.
I'm attaching failed build.log.
Source recipe to reproduce exactly is on python-setuptools-scm-ur, build program on lur.
The text was updated successfully, but these errors were encountered: