Hotfix: Datacube WCS fix + adopt East-West convention #1871
+31
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # doc/releases/1.17.1dev.rst
|
Thanks! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a long-term bug associated with the WCS. With the help of some data collected by @RaymondRemigio, we identified the bug, which was due to incorrectly evaluating the WCS. With this PR, we also update the WCS to adopt the East/West convention of East to the left.
Below is a series of 8 white light images with their WCS locked to the same value. The green circle is the "true" value of the star coordinate. Regardless of the position angle, the WCS of all frames is close to equal. The remaining offsets is possibly the result of not centering the star on REFA and base was not marked during the observations.