fix(forklift): Distinguish deleted project filename error (#18671) (#18925)

* feat(forklift): Distinguish error for archived project file conflicts

Update upload validation to check project lifecycle_status for file conflicts. Provides a more specific error message when the conflict is with an archived project. Fixes #18671

* lint formatted

* style: Apply formatting and remove unused imports

* rollback

* edited

* Reword slightly

---------

Co-authored-by: Dustin Ingram <[email protected]>

Author: Delta17920

tests/unit/forklift/test_legacy.py

@@ -2146,9 +2146,8 @@ def test_upload_fails_with_previously_used_filename(
         assert db_request.help_url.calls == [pretend.call(_anchor="file-name-reuse")]
         assert resp.status_code == 400
         assert resp.status == (
-            "400 This filename has already been used, use a "
-            "different version. "
-            "See /the/help/url/ for more information."
+            "400 This filename was previously used by a file that has since been "
+            "deleted. Use a different version. See /the/help/url/ for more information."
         )
 
     def test_upload_noop_with_existing_filename_same_content(

warehouse/forklift/legacy.py

@@ -1147,9 +1147,8 @@ def file_upload(request):
             )
             raise _exc_with_message(
                 HTTPBadRequest,
-                "This filename has already been used, use a "
-                "different version. "
-                "See "
+                "This filename was previously used by a file that has since been "
+                "deleted. Use a different version. See "
                 + request.help_url(_anchor="file-name-reuse")
                 + " for more information.",
             )