Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SEIR models to observe S2E rather than E2I #2455

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Change SEIR models to observe S2E rather than E2I #2455

merged 1 commit into from
Apr 30, 2020

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Apr 30, 2020

Addresses #2426

This replaces S2E observations with E2I observations in the SEIR models, as suggested by @lucymli.

@martinjankowiak note this may reduce HMC mixing in these models.

Tested

  • refactoring covered by existing tests.

@fritzo fritzo requested a review from eb8680 April 30, 2020 19:50
@martinjankowiak martinjankowiak merged commit d68d95f into dev Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjankowiak martinjankowiak martinjankowiak approved these changes

@eb8680 eb8680 eb8680 approved these changes

Assignees
No one assigned
Labels
awaiting review easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fritzo @eb8680 @martinjankowiak