-
-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate need for CompartmentalModel.transition_bwd() #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
commented
May 31, 2020
def transition_bwd(self, params, prev, curr, t): | ||
R0, tau, rho = params | ||
|
||
def compute_flows(self, prev, curr, t): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the one model where we need a custom .compute_flows()
method.
fritzo
changed the title
Eliminate need for CompartmentalModel.transition_bwd() method
Eliminate need for CompartmentalModel.transition_bwd()
May 31, 2020
38 tasks
2 tasks
martinjankowiak
previously approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great simplification!
martinjankowiak
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2426
This follows ideas from #2513 to replace the
.transition_bwd()
method with a conditioned call of the.transition_fwd()
method, significantly reducing user effort to create a new model. The additional bit of logic to reverse the flow computation is implemented in a new.compute_flows()
method that by default assumes a linear flow terminating in "R", but can be overridden by users to perform arbitrary computations. Only one such override is needed by our current examples.The new
.transition()
method is now called under more interpretations, so various logic needs to be generalized:t < self.duration
now also needs to check forslice
instancesExtendedBinomial
everywhere, not only in.transition_bwd()
I_approx
.Tested