Eliminate need for CompartmentalModel class variables #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjankowiak
previously approved these changes
Jun 8, 2020
fritzo
commented
Jun 8, 2020
Comment on lines
+58
to
+61
| # This adds a __call__ method to satisfy sphinx. | ||
| @patch_dependency('torch.distributions.utils.lazy_property.__call__') | ||
| def _lazy_property__call__(self): | ||
| raise NotImplementedError |
There was a problem hiding this comment.
This is required for any Pyro development after the recent sphinx 3.1 release.
martinjankowiak
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2426
This eliminates the need for classes deriving from
CompartmentalModelto define class variables.full_massand.series, thus easing the task of creating new models. After this PR, those class variables are defined automatically via@lazy_property.This also fixes an issue with sphinx 3.1 that breaks docs building of
@lazy_property(this fix is blocking all Pyro development).Tested
._full_masscomputationexamples/.../sir.py --plotto verify all series are created and plotted