Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak defaults for CompartmentalModel.fit_mcmc() #2563

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Tweak defaults for CompartmentalModel.fit_mcmc() #2563

merged 2 commits into from
Jul 16, 2020

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jul 15, 2020

Addresses #2426

This tweaks .fit_mcmc() default parameters based on experiments in pyro-ppl/sandbox#13 and previous experiments by @martinjankowiak . the new default values are:

  • haar = True
  • haar_full_mass = 10

This PR also updates test_models.py to preserve coverage over the range of parameters, since the defaults have changed.

Tested

  • covered by existing tests in test_models.py

@fritzo fritzo added this to the 1.4 release milestone Jul 15, 2020
@fritzo fritzo requested a review from martinjankowiak July 15, 2020 22:25
@fritzo fritzo mentioned this pull request Jul 15, 2020
Closed
38 tasks
@martinjankowiak martinjankowiak merged commit 924f5e2 into dev Jul 16, 2020
@fritzo fritzo deleted the sir-tweak-defaults branch July 24, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjankowiak martinjankowiak martinjankowiak approved these changes

Assignees
No one assigned
Labels
awaiting review easy
Projects
None yet
Milestone
1.4 release
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @martinjankowiak