Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we verify the Signature? #2

Open
gavinharris-dev opened this issue Nov 30, 2021 · 5 comments
Open

Do we verify the Signature? #2

gavinharris-dev opened this issue Nov 30, 2021 · 5 comments

Comments

@gavinharris-dev
Copy link

Does the code currently verify the authenticity of the signed message in any way? I can see that we are ensuring that the token is correctly formed but are we checking if the signature provided is a signature for this token?

@pyropy
Copy link
Owner

pyropy commented Dec 1, 2021

No there is no code for signature checking currently in place.

@gavinharris-dev
Copy link
Author

Okay cool; I will investigate as this would be important to try preventing spoofing of a token

@pierre-andre-long
Copy link

pierre-andre-long commented Feb 7, 2022

Thanks for this update, i implemented it and it works fine until I changed the implementation of the cardano api call to the new one, check #5 .

@gavinharris-dev
Copy link
Author

Yeah I need to rework the way that I am integrating with the Wallet; CIP-30 changed this process to be more generic.

@gavinharris-dev
Copy link
Author

I've updated my fork to handle the updated 'signData' api response. It was a little different to just returning a 'string' output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants