Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: OLS regression in moran is wrong #186

Closed
martinfleis opened this issue Aug 31, 2024 · 1 comment
Closed

BUG: OLS regression in moran is wrong #186

martinfleis opened this issue Aug 31, 2024 · 1 comment

Comments

@martinfleis
Copy link
Member

Regression line in Moran's plot should be modelled as using lag as independent and z score as dependent. Right now it is the other way, that is why the regression line does not indicate the value of Moran's I.

splot/splot/_viz_esda_mpl.py

Line 279 in 7b6459b

fit = OLS(moran.z[:, None], lag[:, None])

Once switched, the plot is consistent with GeoDa.

xref discussion in #185
@martinfleis martinfleis mentioned this issue Aug 31, 2024
Merged
@martinfleis
Copy link
Member Author

Closed by #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinfleis