Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: move reusable methods from cosmic_gps to methods #3

Open
1 of 3 tasks
jklenzing opened this issue Aug 13, 2020 · 1 comment · Fixed by #30
Open
1 of 3 tasks

ENH: move reusable methods from cosmic_gps to methods #3

jklenzing opened this issue Aug 13, 2020 · 1 comment · Fixed by #30
Labels
enhancement New feature or request
Milestone
0.1.0 Release

Comments

@jklenzing
Copy link
Member

jklenzing commented Aug 13, 2020 •
edited
Loading

A lot of the methods are reusable for other potential CDAAC instruments. We could move these from the cosmic_gps instrument into a methods file that all can pull from.
@jklenzing jklenzing mentioned this issue Aug 13, 2020
Open
3 tasks
@jklenzing jklenzing changed the title ENH: pull out reusable methods from cosmic_gps ENH: move reusable methods from cosmic_gps to methods Aug 14, 2020
@jklenzing jklenzing added the enhancement New feature or request label Aug 18, 2020
@jklenzing jklenzing mentioned this issue Dec 16, 2020
Closed
@jklenzing jklenzing added this to the 0.1.0 Release milestone Dec 16, 2020
@rstoneback
Copy link
Collaborator

Some supporting work has been done over in pulls #17 and #18 to make it easier to move some methods to a different file. I suspect this issue will get addressed, in part, as part of adding cosmic-2 in #4. The additional instrument will make clearer the areas that are common within CDAAC, and not limited to a particular satellite constellation.

@jklenzing jklenzing mentioned this issue Oct 21, 2021
Merged
11 tasks
@jklenzing jklenzing linked a pull request Oct 26, 2021 that will close this issue
ENH: generalize download methods #30
Merged
11 tasks
@jklenzing jklenzing mentioned this issue Dec 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0 Release
Development

Successfully merging a pull request may close this issue.

ENH: generalize download methods pysat/pysatCDAAC
2 participants
@rstoneback @jklenzing