Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove use_header kwarg #131

Closed
aburrell opened this issue Oct 24, 2023 · 0 comments · Fixed by #148
Closed

MAINT: Remove use_header kwarg #131

aburrell opened this issue Oct 24, 2023 · 0 comments · Fixed by #148
Milestone

Comments

@aburrell
Copy link
Member

Description

After pysat 3.2.0 is the latest supported version of pysat, the use_header kwarg will no longer be needed.

Potential impact

  • Is the feature related to an existing problem? This kwarg is currently used in some methods/utilities and in the unit tests
  • How critical is this feature to your workflow? This will raise unnecessary warnings that may alarm the user
  • How wide of an impact to you anticipate this enhancement having? Important for maintance
  • Would this break any existing functionality? No

Potential solution(s)

  • Update usage with a version check
  • Remove entirely after pysat 3.2.0 is the lowest supported version of pysat.

Alternatives

Allow annoying warnings

Additional context

This was a temporary kwarg needed to ease users into a new Instrument and Meta data structure.

@aburrell aburrell added the enhancement New feature or request label Oct 24, 2023
@aburrell aburrell added this to the 1.0.0 milestone Oct 24, 2023
@aburrell aburrell added maintenance and removed enhancement New feature or request labels Oct 24, 2023
@aburrell aburrell modified the milestones: 1.0.0, 0.2.0 Feb 15, 2024
@aburrell aburrell linked a pull request Aug 14, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant