Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Animations #8

Open
nnra6864 opened this issue Jul 2, 2024 · 5 comments
Open

Broken Animations #8

nnra6864 opened this issue Jul 2, 2024 · 5 comments
Assignees

Comments

@nnra6864
Copy link

nnra6864 commented Jul 2, 2024

I can't provide a video because obs is currently broken.
Basically, as soon as I enable this plugin, certain animations break.
Easiest one to spot would be a window moving away when opening a new window next to it.
I am using these settings:

plugin {
    hyprfocus {
    enabled = yes
    animate_floating = yes
    animate_workspacechange = yes
    focus_animation = shrink
    bezier = realsmooth, 0.28,0.29,.69,1.08
    shrink {
        shrink_percentage = 0.9975
        in_bezier = realsmooth
        in_speed = 1
        out_bezier = realsmooth
        out_speed = 2
    }
}
animations {
    enabled = true
    bezier = myBezier, 0.05, 0.9, 0.1, 1.05
	bezier = linear, 0.0, 0.0, 1.0, 1.0	
	bezier = quad, 0.45, 0, 0.55, 1
	bezier = quadOut, 0.5, 1, 0.89, 1
	bezier = expo, 0.87, 0, 0.13, 1
	bezier = expoIn, 0.7, 0, 0.84, 0
	bezier = expoOut, 0.16, 1, 0.3, 1

    animation = windows, 1, 3, expoOut, slide
    animation = windowsOut, 1, 3, expoOut, slide
	animation = windowsMove, 1, 3, expoOut
    
	animation = layersIn, 1, 3, expoOut, fade
	animation = layersOut, 1, 3, expoOut, fade

	animation = fade, 1, 3, expoOut

    animation = border, 1, 3, quadOut
    animation = borderangle, 1, 30, linear, loop

    animation = workspaces, 1, 3, expoOut
	animation = specialWorkspace, 1, 3, expoOut, slidefadevert
}

The animation of the window getting away gets slowed down a considerable amount and it just feels really bad.

@pyt0xic
Copy link
Owner

pyt0xic commented Jul 10, 2024

Let me see if I can reproduce this, I do think the animation code could optimized a bit, does the slow down still happen with the flash animation?

@nnra6864
Copy link
Author

Let me see if I can reproduce this, I do think the animation code could optimized a bit, does the slow down still happen with the flash animation?

Just tested, the slowdown doesn't happen with animation set to flash.

@pyt0xic
Copy link
Owner

pyt0xic commented Jul 10, 2024

That's interesting, my best guess is that, when opening/closing a second window on the same workspace, it looks laggy/glitchy because Hyprland has to display the shrink animation + normal window animations.

I think this will be pretty easy to fix by hooking into the window opened and window closed events so we can skip the focus animation for those windows...

@pyt0xic pyt0xic self-assigned this Jul 10, 2024
@Azarattum
Copy link

For me, enabling shrink animation also affects other window open/close animations (their curves and speed) making shirk unusable in my setup... Also, I wonder if it would be possible to actually scale window making the content smaller and not just decreasing the container size?.. I think it would look a lot nicer.

@Azarattum
Copy link

Azarattum commented Nov 26, 2024

Also, I think, flash completely ignores animation speed.

upd: reloading hyprland fixed the animation speed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants