Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tempfile from Patcher #191

Closed
mrbean-bremen opened this issue May 28, 2017 · 3 comments
Closed

Remove tempfile from Patcher #191

mrbean-bremen opened this issue May 28, 2017 · 3 comments
Assignees
@mrbean-bremen
Labels
infrastructure

Comments

@mrbean-bremen
Copy link
Member

The tempfile module seems not to depend on any low level file system code - It uses the modules os, io and shutil directly. For that reason, it can safely be removed from Patcher.

This ensures that the correct implementation of tempfile is used without the need for a fake implementation, if using Patcher.

See #189.
@mrbean-bremen mrbean-bremen mentioned this issue May 28, 2017
Closed
@jmcgeheeiv
Copy link
Contributor

I presume you mean "...safely removed from Patcher.SKIPNAMES"?

Masterful.

@mrbean-bremen
Copy link
Member Author

No, I mean remove it completely, like I did with glob (provided I didn't overlook something).

@jmcgeheeiv
Copy link
Contributor

Yes, of course you would also remove the module itself.

@mrbean-bremen mrbean-bremen self-assigned this Jun 21, 2017
@mrbean-bremen mrbean-bremen mentioned this issue Jun 21, 2017
Closed
@mrbean-bremen mrbean-bremen mentioned this issue Jun 30, 2017
Closed
@Quibi Quibi mentioned this issue Nov 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrbean-bremen mrbean-bremen

Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmcgeheeiv @mrbean-bremen