Policies on reviewing and merging

[diazona]

@redtoad @coordt Since I know we're not all going to be active contributors all the time here, I wanted to get a read from you on what should be required before a PR gets merged. Should each of us feel free to merge pull requests as we see fit? Or should we try to get agreement from two or all three of us before making changes? And/or should we have a rule that for PRs made by one of us, someone other than the original author needs to approve it first?

I'm happy to go ahead with whatever works, I just don't want to subvert any expectations you may have.

Once we decide, maybe this could get formalized in a CONTRIBUTING.md file or something. I'd be happy to write it up.

[redtoad]

I'd say "one of the maintainers" needs to approve

[coordt]

That works for me.

…

On Mon, Nov 29, 2021 at 11:44 AM Sebastian Rahlf ***@***.***> wrote: I'd say "one of the maintainers" needs to approve — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAXQSV6PSVW5F2NNWUAR6TUOO3WVANCNFSM5I4TMCJQ> .

[diazona]

Thanks for chiming in. Is that one of the maintainers other than the author, or do you mean we should just merge our own PRs (presumably after waiting a reasonable time for comments)?

I'm guessing you meant the former, just want to be clear.

[coordt]

I am fine with either or both. I would prefer having another person look it over, but there should be a time limit, after which the author can merge in the branch.

[diazona]

Makes sense. Maybe a week? Two weeks? 🤷

[diazona]

@coordt @redtoad any input here?