Add support for AIX

[jokurz]

Add support for AIX. Currently disto returns the following for a AIX 7.2:

{
    "codename": "",
    "id": "aix",
    "like": "",
    "version": "2",
    "version_parts": {
        "build_number": "",
        "major": "2",
        "minor": ""
    }
}

Source could be cmd oslevel:

$ oslevel
7.2.0.0

7 --> major
2 --> minor

[nir0s]

Can you share the release file?

[jokurz]

As far as I know there is no release file on AIX.

[nir0s]

There must be something.. lsb.. something.. otherwise how would distro know that it's aix?

[jokurz]

It seems that this information was gathered from uname -rs:

$ uname -rs
AIX 2

[HorlogeSkynet]

Hey @jokurz, would it be possible to read these version components from a file instead of calling oslevel ? Thanks 🙇

[jokurz]

@HorlogeSkynet - I am not aware of such a file. I would fully understand if you will not support AIX as the platform might not be the first choice for python development.

[HorlogeSkynet]

@jokurz thanks for your fast feedback ! We'll do our best to support (and maintain) what distro should.
I was asking about a specific "release" file, as sourcing such would be faster than calling another external program. Do you know a substitute for Linux strace command that you could run against oslevel to see what it does ? Bye 👋

[nir0s]

@HorlogeSkynet, while I agree that a file would be nicer, I think that we can simply try to execute oslevel as a last resort (assuming nothing else is found, e.g. release file, uname, etc..).

If that's the case, it won't cost anything, as oslevel will indeed only run when no other option is available (supposedly, only on AIX, AFAIK).

WDYT?

[HorlogeSkynet]

@nir0s Unless I'm missing something here, I don't think it would be that easy as uname -rs output is definitely working (see #241 (comment)) 🙄

[nir0s]

Hehe, I'm the one missing something. I didn't read the previous comments.

[HorlogeSkynet]

@nir0s @jokurz So it looks like we could be doing something like that in version method (naive pseudo-code here, implementation must be tougher and tests written of course) :

    def version(self, pretty: bool = False, best: bool = False) -> str:
        versions = [
            # current existing candidates list...
        ]
        if sys.platform.startswith('aix'):
            versions.insert(0, check_output("oslevel"))

---

@jokurz Homework chores if you don't mind :

• verify that somehow we cannot retrieve oslevel output another way ;
• check whether passing a specific flag to oslevel would be relevant in our case, according to AIX's terminology (manual).

---

Thanks, bye 👋

[nir0s]

@HorlogeSkynet, sounds good. However, while I don't know AIX, it doesn't make sense to me that there isn't a file with that info. Does AIX have a magical way of storing this info that we can't read?

[HorlogeSkynet]

Closing here, please see #311.
An official review is expected from you @nir0s, but I'd be interested from yours too @jokurz. Bye 👋