Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the jsonschema==4.0 interface and test against new schema versions #89

Open
Zac-HD opened this issue Oct 3, 2021 · 2 comments
Open

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Oct 3, 2021

See https://github.com/Julian/jsonschema/blob/main/CHANGELOG.rst#v400 and update tests etc. to check for the (partially) supported Drafts 2020-12 and 2019-09. Also maybe the False != 0 validation fix will allow some test skips or workarounds to be removed?

array items have changed semantics in new drafts too, yay; we'll need to test against more schemas and update gen_schemas to support the new keywords 😭

@thatguysimon
Copy link

Hi @Zac-HD!
What's the latest on this? I'd be happy to help 👍🏻

@Zac-HD
Copy link
Member Author

Zac-HD commented Jan 24, 2023

It's waiting on volunteers, so your contribution would be very appreciated! I'd suggest a multi-step process, so that PRs can stay small and reviewable:

  • get currently-supported schema versions working with jsonschema >= 4. At this point we can bump the minimum version, which should make things easier
  • add new schemas to the test suite, and then make sure that the new keywords are supported. This is probably the fiddlier part - fortunately the tests are really sensitive, so while you might need to extend them for new features I'm confident that if they pass, the code is fine.

@Zac-HD Zac-HD changed the title Use jsonschema==4.0 Use the jsonschema==4.0 interface and test against new schema versions Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants