Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect architectures supported by pbs_installer in tests #10261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Respect architectures supported by pbs_installer in tests #10261

wants to merge 1 commit into from

Conversation

frenzymadness
Copy link

@frenzymadness frenzymadness commented Mar 7, 2025 •
edited by sourcery-ai bot
Loading

Fixes: #10260

Pull Request Check List

Resolves: #10260

This is a fix for tests so there is nothing to test or document.

Summary by Sourcery

Ensure tests respect the architectures supported by pbs_installer, skipping tests on unsupported platforms.

Tests:

  • Add a helper function to determine if an architecture is supported by pbs_installer.
  • Skip tests on platforms not supported by pbs_installer.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Mar 7, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request addresses issue #10260 by modifying tests to respect the architectures supported by pbs_installer. A helper function pbs_installer_supported_arch was added to determine if the current architecture is supported. The tests in test_python_list.py and test_manager.py were updated to use this helper function.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a helper function to determine if the current architecture is supported by pbs_installer.
  • Added pbs_installer_supported_arch function to tests/helpers.py.
  • The function checks if the architecture is in the list of supported architectures by pbs_installer.
 tests/helpers.py
Updated tests to respect architectures supported by pbs_installer.
  • Added a check for pbs_installer_supported_arch in test_list_all in tests/console/commands/python/test_python_list.py.
  • Added a check for pbs_installer_supported_arch in test_find_downloadable_versions in tests/utils/env/python/test_manager.py.
 tests/console/commands/python/test_python_list.py
tests/utils/env/python/test_manager.py

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 7, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @frenzymadness - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment to explain why pbs_installer_supported_arch is needed.
  • It might be better to move the pbs_installer_supported_arch check directly into the tests where it's used.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@frenzymadness frenzymadness force-pushed the fix_arch_downloadable branch 2 times, most recently from 946962a to 2ec98aa Compare March 7, 2025 11:21
@frenzymadness frenzymadness force-pushed the fix_arch_downloadable branch from 2ec98aa to 20ca44c Compare March 7, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_find_downloadable_versions fails on ppc64le
1 participant
@frenzymadness