-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poetry 2.0 check deprecation warnings producing errors when fixed #9965
Comments
For now the check and sync job are failing because pip already has 2.0.0 available, but we are counting on poetry < 2.0.0. The check is not easy to fix as it's producing deprecated warnings that are producing errors when fixed. The error is reported here python-poetry/poetry#9965 Signed-off-by: Michal Konecny <[email protected]>
Does not reproduce. Indeed poetry itself is an example of a project that does this, and its pipeline shows no such failure |
that is not what this issue says, please read more carefully. What you are saying is duplicate #9958. |
@dimbleby Thanks. I see the issue you linked is already closed. I'll create a new issue to complain about exiting with an error code when there are only warnings. Edit: It appears that exiting with error code |
I'm going to chime in having the same observations as @Zlopez here with a couple of my projects. If those are warnings - a non-zero exit code coming as a result of an impending release breaks things. Context. https://github.com/fedora-infra/mdapi/actions/runs/12646184815/job/35236500953 Context. https://github.com/fedora-infra/firmitas/actions/runs/12624139412/job/35173984552#step:5:21 |
@gridhead you too are having a reading fail. This issue is about the claim that poetry reports errors even after the warnings are resolved. You want one of the linked issues. |
When trying to reproduce it I found out that this is only happening in venv created by older version of poetry, when using In this case it seems that the better solution is to not return exit code 1 on warnings as mentioned above. |
Then please close this as a duplicate |
Description
When running
poetry check
on old pyproject.toml it will produce following error:Warning: [tool.poetry.name] is deprecated. Use [project.name] instead.
When moving the
name
to[project]
section it will produce the following:Both ways are producing return code 1, which makes it hard to recognize when it actually fails.
Workarounds
Stay on the version < 2.0.0
Poetry Installation Method
pip
Operating System
Fedora 41
Poetry Version
Poetry (version 2.0.0)
Poetry Configuration
Python Sysconfig
Example pyproject.toml
Poetry Runtime Logs
The text was updated successfully, but these errors were encountered: