Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-defined meters #9

Open
njsmith opened this issue Oct 7, 2018 · 0 comments
Open

User-defined meters #9

njsmith opened this issue Oct 7, 2018 · 0 comments

Comments

@njsmith
Copy link
Member

njsmith commented Oct 7, 2018

Right now we only have a small set of built-in meters. It would be nice to allow people to define their own meters, I think. I could be wrong though? I'm not actually sure what the use cases for this would be, so it'd be nice to see some. But my initial idea was that we'd allow people to pass meters=[...], and then the max_* kwargs would just be convenience shorthands for adding some commonly used meters to this list.

There's some machinery to support this already (e.g. the split between "meters" and "meter states"), but I decided not to expose it yet because (a) use cases could be clearer, (b) not at all certain that we've got the meter API done correctly. In particular, I suspect that keyed meters (#8) will require some changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant