more tempfile fixes

Author: dhellmann

ChangeLog

@@ -1,5 +1,9 @@
 2010-05-16  Doug Hellmann  <[email protected]>
 
+	* virtualenvwrapper.sh (virtualenvwrapper_tempfile): Set a default
+	suffix of "hook" and explicitly report when we detect an error
+	condition.
+
 	* Makefile (PYTHON26): Use which to find python2.6, the default
 	interpreter, so we can run the tests as "make test-quick" on other
 	hosts.

tests/test_cp.sh

@@ -6,6 +6,8 @@ test_dir=$(dirname $0)
 
 export WORKON_HOME="${TMPDIR:-/tmp}/WORKON_HOME"
 
+unset HOOK_VERBOSE_OPTION
+
 setUp () {
     rm -rf "$WORKON_HOME"
     mkdir -p "$WORKON_HOME"

virtualenvwrapper.sh

@@ -93,7 +93,14 @@ virtualenvwrapper_verify_workon_home () {
 # Expects 1 argument, the suffix for the new file.
 virtualenvwrapper_tempfile () {
     # Note: the 'X's must come last
-    mktemp -t "virtualenvwrapper-$1-XXXXXX"
+    typeset suffix=${1:-hook}
+    mktemp -t "virtualenvwrapper-$suffix-XXXXXXXXXX"
+    if [ $? -ne 0 ]
+    then
+        echo "ERROR: virtualenvwrapper could not create a temporary file name." 1>&2
+        return 1
+    fi
+    return 0
 }
 
 # Run the hooks