Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The max_val parameter in HeatMap is still necessary #1547

Closed
karim-soufi opened this issue Dec 7, 2021 · 1 comment
Closed

The max_val parameter in HeatMap is still necessary #1547

karim-soufi opened this issue Dec 7, 2021 · 1 comment

Comments

@karim-soufi
Copy link

Hello,

I think the max_val is still necessary.
For example if I want to generate two heatmaps with for two different dataframes, the calculated max would be different, hence I cant compare the both of them without having the same max_val being referenced.

@Conengmo
Copy link
Member

This relates to #1271.

Looks like the max_val parameter actually doesn't exist in the underlying JS plugin! See https://github.com/Leaflet/Leaflet.heat#reference. The parameter is called max.

You can supply this parameter as a keyword argument now already:

HeatMap(max=1.0)

If this is an important parameter to have, we could add it to the class 'officially'. PRs welcome.

If somebody can report back on whether the max parameter actually works, that's helpful as well.

@Conengmo Conengmo changed the title The max_val parameter is still necessary The max_val parameter in HeatMap is still necessary Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants