Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release process needs testing #53

Closed
jaraco opened this issue Nov 10, 2021 · 7 comments
Closed

Release process needs testing #53

jaraco opened this issue Nov 10, 2021 · 7 comments

Comments

@jaraco
Copy link
Member

jaraco commented Nov 10, 2021

In #48, I attempted to cut a new release, but when I followed the instructions, nothing happened. As I was working to figure it out, I found other problems (like the travis-ci badge is a 404 and the release branch didn't run in CI).

@Mariatta
Copy link
Member

I will try to release it manually by hand today.

@Mariatta
Copy link
Member

I've published v 2.1.0 to PyPI: https://pypi.org/project/cherry_picker/2.1.0/

@jaraco
Copy link
Member Author

jaraco commented Nov 10, 2021

Oh, nice. Thanks for that!

In #54, I converted the release process to rely on Github Actions. It's based on the same process I use with my other projects, but the diff is untested.

It does require your help, though. Can you add a secret to the project? PYPI_TOKEN and with a value containing the token for PyPI? Then next time we have a release, we can see if the new process works.

@Mariatta
Copy link
Member

Sure, do I add it as "Environment secret" or "repository secret"? Wasn't sure what's the difference there.

@jaraco
Copy link
Member Author

jaraco commented Nov 10, 2021

Oh, I was unaware of the distinction. I use repository secrets, so I'd recommend that.

@Mariatta
Copy link
Member

Ok. The PYPI_TOKEN has been added. Thanks.

@jaraco jaraco changed the title Release process is broken Release process needs testing Nov 10, 2021
@hugovk
Copy link
Member

hugovk commented Nov 12, 2023

We're now using Trusted Publishers, hopefully things will be more better now: #94.

@hugovk hugovk closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants