Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider laxing the requirements for maintenance branch names? #69

Closed
Jackenmen opened this issue Jul 10, 2022 · 1 comment · Fixed by #70
Closed

Consider laxing the requirements for maintenance branch names? #69

Jackenmen opened this issue Jul 10, 2022 · 1 comment · Fixed by #70

Comments

@Jackenmen
Copy link
Contributor

Jackenmen commented Jul 10, 2022

I know that this is a tool primarily for CPython but I found myself in a use case where I could benefit from cherry-picker's help but the branch name I want to backport to isn't version-like. To be specific, I want to use it with a branch named stable because it allows me to replace ReadTheDocs's stable version without going through the release process:
https://docs.readthedocs.io/en/stable/versions.html#versioned-documentation

I can't seem to find a good reason for this limitation, the only thing the version in the branch appears to be used for is sorting - it wouldn't be too hard to primarily sort by version but fallback to lexicographic order if the branch doesn't contain a version. If the concern is that user passes the program something that is a commit rather than a branch name then we could enforce that it is in a different way (though you already do this indirectly when creating a backport branch using upstream/MAINTENANCE_BRANCH_NAME as a base which doesn't work with commits).

I'd be happy to implement this if accepted by the way.

@webknjaz
Copy link
Contributor

xref #70

@github-project-automation github-project-automation bot moved this from Todo to Done in Sprint 2024 Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants