Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enum] make some private attributes public #112328

Closed
ethanfurman opened this issue Nov 23, 2023 · 4 comments · Fixed by #121720
Closed

[Enum] make some private attributes public #112328

ethanfurman opened this issue Nov 23, 2023 · 4 comments · Fixed by #121720
Assignees
@ethanfurman
Labels
3.13 bugs and security fixes deferred-blocker docs Documentation in the Doc dir stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@ethanfurman
Copy link
Member

ethanfurman commented Nov 23, 2023 •
edited by bedevere-app bot
Loading

Feature or enhancement

Make _EnumDict, _EnumDict._member_names, and possibly other private names public.

This is to make subclassing EnumType and other advanced behavior supported, such as having multiple values per member.

Linked PRs
@ethanfurman ethanfurman added type-feature A feature request or enhancement stdlib Python modules in the Lib dir 3.13 bugs and security fixes labels Nov 23, 2023
@ethanfurman ethanfurman self-assigned this Nov 23, 2023
@ethanfurman ethanfurman added the docs Documentation in the Doc dir label Nov 23, 2023
@bedevere-app bedevere-app bot mentioned this issue Nov 29, 2023
Merged
ethanfurman added a commit that referenced this issue Dec 5, 2023
@ethanfurman @AlexWaygood @sobolevn
gh-112328: [Enum] Make some private attributes public. (GH-112514)
de6bca9 
* [Enum] Make some private attributes public.

- ``_EnumDict`` --> ``EnumDict``
- ``EnumDict._member_names`` --> ``EnumDict.member_names``
- ``Enum._add_alias_``
- ``Enum._add_value_alias_``

---------

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
@hugovk
Copy link
Member

hugovk commented Dec 11, 2023

The PR has been merged, shall we close this, or is there more to do?

@ethanfurman
Copy link
Member Author

Closing, thanks for the reminder.

aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@ethanfurman @AlexWaygood
@sobolevn @aisk
pythongh-112328: [Enum] Make some private attributes public. (pythonG…
23f9995 
…H-112514)

* [Enum] Make some private attributes public.

- ``_EnumDict`` --> ``EnumDict``
- ``EnumDict._member_names`` --> ``EnumDict.member_names``
- ``Enum._add_alias_``
- ``Enum._add_value_alias_``

---------

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
@JelleZijlstra
Copy link
Member

EnumDict is now public and included in Enum.__all__, but it is not documented at https://docs.python.org/3.13/library/enum.html or mentioned in the What's New for 3.13.

@JelleZijlstra JelleZijlstra reopened this Jun 1, 2024
@JelleZijlstra JelleZijlstra mentioned this issue Jun 1, 2024
Merged
@u2rafi
Copy link
Contributor

u2rafi commented Jul 13, 2024

I am working on documenting this.

@u2rafi u2rafi mentioned this issue Jul 13, 2024
Merged
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@ethanfurman @AlexWaygood
@sobolevn @Glyphack
pythongh-112328: [Enum] Make some private attributes public. (pythonG…
54c174f 
…H-112514)

* [Enum] Make some private attributes public.

- ``_EnumDict`` --> ``EnumDict``
- ``EnumDict._member_names`` --> ``EnumDict.member_names``
- ``Enum._add_alias_``
- ``Enum._add_value_alias_``

---------

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Sep 4, 2024
Merged
ethanfurman added a commit that referenced this issue Dec 19, 2024
@u2rafi @webknjaz @ethanfurman
gh-112328: Document EnumDict in docs and release notes (GH-121720)
39e69a7 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
ethanfurman added a commit that referenced this issue Dec 20, 2024
@encukou @u2rafi
@webknjaz @ethanfurman
gh-112328: Make EnumDict usable on its own and document it (GH-123669)
2a66dd3 
Co-authored-by: Rafi <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Dec 20, 2024
Merged
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Dec 23, 2024
@u2rafi @webknjaz
@ethanfurman @srinivasreddy
pythongh-112328: Document EnumDict in docs and release notes (pythonG…
9c87b55 
…H-121720)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Dec 23, 2024
@encukou @u2rafi
@webknjaz @ethanfurman @srinivasreddy
pythongh-112328: Make EnumDict usable on its own and document it (pyt…
8d4f62d 
…honGH-123669)

Co-authored-by: Rafi <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
ethanfurman added a commit that referenced this issue Dec 24, 2024
@ethanfurman @encukou
[3.13] gh-112328: Make EnumDict usable on its own and document it (GH…
875e49f 
…-123669) (GH-128142)

Co-authored-by: Petr Viktorin <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@u2rafi @webknjaz
@ethanfurman @srinivasreddy
pythongh-112328: Document EnumDict in docs and release notes (pythonG…
8f260c0 
…H-121720)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@encukou @u2rafi
@webknjaz @ethanfurman @srinivasreddy
pythongh-112328: Make EnumDict usable on its own and document it (pyt…
ff26364 
…honGH-123669)

Co-authored-by: Rafi <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanfurman ethanfurman

Labels
3.13 bugs and security fixes deferred-blocker docs Documentation in the Doc dir stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
Release and Deferred blockers 🚫
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-112328: Document EnumDict in docs and release notes u2rafi/cpython
4 participants
@JelleZijlstra @hugovk @u2rafi @ethanfurman