gh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checks
#128322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
changed the title
LIBS during sqlite3 library build checksLIBS instead of LDFLAGS during sqlite3 library build checks
erlend-aasland
approved these changes
Dec 30, 2024
|
Thanks for the review! |
This was referenced Dec 30, 2024
erlend-aasland
added
needs backport to 3.12
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 30, 2024
…quirements (pythonGH-128322) (cherry picked from commit 81376fe) Co-authored-by: Zanie Blue <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 30, 2024
…quirements (pythonGH-128322) (cherry picked from commit 81376fe) Co-authored-by: Zanie Blue <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
|
GH-128355 is a backport of this pull request to the 3.12 branch. |
|
GH-128356 is a backport of this pull request to the 3.13 branch. |
erlend-aasland
added a commit
that referenced
this pull request
Dec 30, 2024
…equirements (GH-128322) (#128355) (cherry picked from commit 81376fe) Co-authored-by: Zanie Blue <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this pull request
Dec 30, 2024
…equirements (GH-128322) (#128356) (cherry picked from commit 81376fe) Co-authored-by: Zanie Blue <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128321
See the issue for context.
There are a few alternative approaches we could take, such as:
-lmduring checks (which would over-link)PKG_CHECK_MODULES_STATICinstead ofPKG_CHECK_MODULESwhen shared libraries are disabledI'm not really sure of the trade-offs. This seems like the simplest approach to unblock users who can set
PKG_CONFIGto include the--staticflag as mentioned in https://bugs.freedesktop.org/show_bug.cgi?id=19541#c7sqlite3fails checks due to missing-lm#128321