Skip to content

Use implemenation-specific I/O open / constructors in tests #133982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmaloney opened this issue May 13, 2025 · 0 comments
Open

Use implemenation-specific I/O open / constructors in tests #133982

cmaloney opened this issue May 13, 2025 · 0 comments
Labels
tests Tests in the Lib/test dir topic-IO type-bug An unexpected behavior, bug, or error

Comments

@cmaloney
Copy link
Contributor

cmaloney commented May 13, 2025

Bug report

Bug description:

Most I/O tests are setup for running on multiple implementations. As tests have been added for bug fixes some now use open() or the class constructor directly instead of the self. version which does implementation delegation. This means that some features are not tested when the I/O module implementation is changed (ex. _io, _pyio).

I'm planning to use this as a meta issue as I find individual cases and update the test, fixing up implementations as needed to get tests passing.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

@cmaloney cmaloney added the type-bug An unexpected behavior, bug, or error label May 13, 2025
cmaloney added a commit to cmaloney/cpython that referenced this issue May 13, 2025
@ZeroIntensity ZeroIntensity added the tests Tests in the Lib/test dir label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir topic-IO type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants