REPL colorizes even inside interactive commands

[olgarithms]

Bug report

Bug description:

print("hello")
help
print  # inside interactive help 
quit.  # inside interactive help 
print("bye")

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Linked PRs

• gh-136924: Suspend REPL colorizing when in a REPL interactive command #136926

[olgarithms]

I am working on this and will open a proposed PR.

[StanFromIreland]

I do not think this is that big an issue, it is the same as the repl, builtins are highlighted, the rest are not? Your proposed PR even stops colorizing the prompts, which I think is a useful feature. cc @ambv @pablogsal

[olgarithms]

Thanks for looking!

I do not think this is that big an issue, it is the same as the repl, builtins are highlighted, the rest are not?

It shouldn't be. When you enter the help system, anything you type isn't python code it is a help query, and thus shouldn't be highlighted. We discussed this issue with @ambv during EuroPython sprints.

Your proposed PR even stops colorizing the prompts, which I think is a useful feature.

You are right, this is unfortunate, but it also mimics the history behavior (which is where my patch was added). I am not sure if this was an intentional feature (I assume yes), but since the help or other repl commands aren't saved in history I kept the behavior consistent. Happy to hear otherwise!

[StanFromIreland]

I see, I guess colorizing help should be a separate issue then.