From 99d912f132aca24451334b9c01cb3ffcafe389b3 Mon Sep 17 00:00:00 2001 From: Jelle Zijlstra Date: Mon, 14 Apr 2025 07:30:02 -0700 Subject: [PATCH] annotations: Add tests to check that async comprehensions produce errors This already works correctly but I forgot to test for it. --- Lib/test/test_type_annotations.py | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/Lib/test/test_type_annotations.py b/Lib/test/test_type_annotations.py index 31df7668db0976..f903f9bb51f919 100644 --- a/Lib/test/test_type_annotations.py +++ b/Lib/test/test_type_annotations.py @@ -387,10 +387,21 @@ class Nested: ... self.assertEqual(Outer.__annotations__, {"x": Outer.Nested}) def test_no_exotic_expressions(self): - check_syntax_error(self, "def func(x: (yield)): ...", "yield expression cannot be used within an annotation") - check_syntax_error(self, "def func(x: (yield from x)): ...", "yield expression cannot be used within an annotation") - check_syntax_error(self, "def func(x: (y := 3)): ...", "named expression cannot be used within an annotation") - check_syntax_error(self, "def func(x: (await 42)): ...", "await expression cannot be used within an annotation") + preludes = [ + "", + "class X:\n ", + "def f():\n ", + "async def f():\n ", + ] + for prelude in preludes: + with self.subTest(prelude=prelude): + check_syntax_error(self, prelude + "def func(x: (yield)): ...", "yield expression cannot be used within an annotation") + check_syntax_error(self, prelude + "def func(x: (yield from x)): ...", "yield expression cannot be used within an annotation") + check_syntax_error(self, prelude + "def func(x: (y := 3)): ...", "named expression cannot be used within an annotation") + check_syntax_error(self, prelude + "def func(x: (await 42)): ...", "await expression cannot be used within an annotation") + check_syntax_error(self, prelude + "def func(x: [y async for y in x]): ...", "asynchronous comprehension outside of an asynchronous function") + check_syntax_error(self, prelude + "def func(x: {y async for y in x}): ...", "asynchronous comprehension outside of an asynchronous function") + check_syntax_error(self, prelude + "def func(x: {y: y async for y in x}): ...", "asynchronous comprehension outside of an asynchronous function") def test_no_exotic_expressions_in_unevaluated_annotations(self): preludes = [ @@ -406,6 +417,9 @@ def test_no_exotic_expressions_in_unevaluated_annotations(self): check_syntax_error(self, prelude + "(x): (y := 3)", "named expression cannot be used within an annotation") check_syntax_error(self, prelude + "(x): (__debug__ := 3)", "named expression cannot be used within an annotation") check_syntax_error(self, prelude + "(x): (await 42)", "await expression cannot be used within an annotation") + check_syntax_error(self, prelude + "(x): [y async for y in x]", "asynchronous comprehension outside of an asynchronous function") + check_syntax_error(self, prelude + "(x): {y async for y in x}", "asynchronous comprehension outside of an asynchronous function") + check_syntax_error(self, prelude + "(x): {y: y async for y in x}", "asynchronous comprehension outside of an asynchronous function") def test_ignore_non_simple_annotations(self): ns = run_code("class X: (y): int")