Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ordering #195

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Improve ordering #195

merged 5 commits into from
Sep 23, 2024

Conversation

AA-Turner
Copy link
Member

This PR mainly exists to run the rebuild loop on language-version pairs in definition order rather than reversed (so we run en/3.14 first rather than zh-tw/3.14), and I cleaned up a few other things too. Perhaps easiest to review by commit.

A

Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me :)

@hugovk hugovk merged commit 193b749 into python:main Sep 23, 2024
5 checks passed
@AA-Turner AA-Turner deleted the ordering branch September 23, 2024 19:34
@AA-Turner
Copy link
Member Author

A rebuild loop has just started, and en/3.14 is first up, this PR did indeed work!

adam@docs:~$ tail -f /var/log/docsbuild/docsbuild.log
...
2024-09-23 23:07:01,513 INFO: Full build start.
2024-09-23 23:07:01,514 DEBUG: Starting new HTTPS connection (1): raw.githubusercontent.com:443
2024-09-23 23:07:01,646 DEBUG: https://raw.githubusercontent.com:443 "GET /python/devguide/main/include/release-cycle.json HTTP/11" 200 0
2024-09-23 23:07:01,717 DEBUG en/3.14: Run: 'git -C /srv/docsbuild/cpython fetch'
2024-09-23 23:07:02,780 INFO en/3.14: Running.
2024-09-23 23:07:02,780 DEBUG en/3.14: Run: 'git -C /srv/docsbuild/cpython show-ref -s origin/main'
2024-09-23 23:07:02,785 DEBUG en/3.14: Run: 'git -C /srv/docsbuild/cpython reset --hard 8a2baedc4bcb606da937e4e066b4b3a18961cace --'
2024-09-23 23:07:04,944 DEBUG en/3.14: Run: 'git -C /srv/docsbuild/cpython clean -dfqx'
2024-09-23 23:07:05,217 DEBUG en/3.14: Run: 'git -C /srv/docsbuild/cpython rev-parse HEAD'
2024-09-23 23:07:05,220 DEBUG en/3.14: Run: 'git -C /srv/docsbuild/cpython diff --name-only 342e654b8eda24c68da64cc21bc9583e480d9e8e 8a2baedc4bcb606da937e4e066b4b3a18961cace'
2024-09-23 23:07:05,245 INFO en/3.14: Should rebuild: Doc/ has changed (from 342e654b8eda24c68da64cc21bc9583e480d9e8e to 8a2baedc4bcb606da937e4e066b4b3a18961cace)
2024-09-23 23:07:05,245 DEBUG en/3.14: Run: '/srv/docsbuild/venv/bin/python -m venv /srv/docsbuild/venv-3.14'
2024-09-23 23:07:07,958 DEBUG en/3.14: Run: '/srv/docsbuild/venv-3.14/bin/python -m pip install --upgrade --upgrade-strategy=eager python-docs-theme jieba -rrequirements.txt'
2024-09-23 23:07:10,765 DEBUG en/3.14: Run: '/srv/docsbuild/venv-3.14/bin/python -m pip freeze --all'
2024-09-23 23:07:11,716 INFO en/3.14: Build start.
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants