Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add section on managing/adding backups #475

Open
JacobCoffee opened this issue Aug 19, 2024 · 2 comments
Open

Docs: Add section on managing/adding backups #475

JacobCoffee opened this issue Aug 19, 2024 · 2 comments
Assignees
Labels
Documentation Relates to the psf.infra.io documentation

Comments

@JacobCoffee
Copy link
Member

What

When adding new backup files/directories, we will need to add related keys for this. This and other things (like SSH key changes when hosts upgrade/change) should be documented


Keys are not being made for the two new entries :(

root@hg:~# ls /etc/backup/.ssh
id_rsa_python-hg

from

{{ backup }}-ssh-key:
  file.managed:
    - name: /etc/backup/.ssh/id_rsa_{{ backup }}
    - contents_pillar: backup-secret:directories:{{ backup }}:ssh_key
    - user: {{ config['user'] }}
    - mode: "0600"
    - show_diff: False 

probably due to missing pillar data in the secrets file for backup

Originally posted by @JacobCoffee in #474 (comment)

@JacobCoffee JacobCoffee self-assigned this Aug 19, 2024
@JacobCoffee JacobCoffee added the Documentation Relates to the psf.infra.io documentation label Aug 19, 2024
@ewdurbin
Copy link
Member

I wonder if we should re-evaluate this and refactor our backup setup to a "key per host" rather than a "key per backup".

It was some time ago, but I think I initially set it up as "key per backup" so that we could have non-root users running backups. In practice that has never occurred.

@ewdurbin
Copy link
Member

These are out of sync because we store the private keys in the secret pillar data. I think we could also just have salt generate them though which would avoid the issue we're running into here (creating a backup doesn't create the key).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Relates to the psf.infra.io documentation
Projects
None yet
Development

No branches or pull requests

2 participants