Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkpoints to existing Sigstore bundles #161

Closed
sethmlarson opened this issue Aug 9, 2024 · 3 comments
Closed

Add checkpoints to existing Sigstore bundles #161

sethmlarson opened this issue Aug 9, 2024 · 3 comments
Assignees

Comments

@sethmlarson
Copy link
Collaborator

sethmlarson commented Aug 9, 2024

This is the second part of python/cpython#122785, in addition to #159.

In short, the bundles that Sigstore CLI v1.x was generating didn't include all the necessary information to be able to verify up to the current standards of a Sigstore CLI (both Python and Go's CLI don't like our old bundles) to the point of calling them malformed or maliciously modified:

[09:14:32] ERROR    An issue occurred while parsing the Sigstore bundle.                                                                                                                           errors.py:41                                                                                                                                                                                                               
                    The provided bundle is malformed and may have been modified maliciously.                                                                                                                                                                                                                                                                                                                                  
                    Additional context:                                                                                                                                                                                                                                                                                                                                                                                       
                    entry must contain inclusion proof, with checkpoint                                                                                                                                                                                                                                                                                                                                                       
                    For detailed error information, run sigstore with the `--verbose` flag. 

So we have a bunch of bundles without checkpoints on python.org/download. I pinged the Python Sigstore team and they're creating a subcommand to add the checkpoint to an existing Sigstore bundle without needing to re-sign every artifact.

In anticipation of that subcommand being available, I've generated the following script to fix and check all Sigstore bundles for CPython:

https://github.com/sethmlarson/migrate-cpython-sigstore-bundles

@sethmlarson
Copy link
Collaborator Author

sethmlarson commented Aug 26, 2024

Discovered that the 3.11.4 Sigstore bundles weren't signed correctly (the wrong identity provider was used, but the correct email for Pablo), so we'll have to fix that first before we can proceed, but the script is complete and has been tested locally.

@sethmlarson
Copy link
Collaborator Author

3.11.4 bundles are fixed, so now we can proceed. Will work with @JacobCoffee to migrate the bundles on the downloads server with the above script.

@sethmlarson
Copy link
Collaborator Author

Sigstore bundles have been migrated and are verifying properly now:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant