Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChooseQuantizationParams is not checking for min/max validity like Pytorch does #1590

Open
zhengwy888 opened this issue Feb 10, 2023 · 1 comment
Open

ChooseQuantizationParams is not checking for min/max validity like Pytorch does #1590

zhengwy888 opened this issue Feb 10, 2023 · 1 comment

Comments

@zhengwy888
Copy link

Hi, in Pytorch's ChooseQuantizationParams they check for min <= max, but FBGEMM doesn't. This causes discrepancy in the behavior of pytorch code when compiled with USE_FBGEMM=1 and USE_FBGEMM=0. Can FBGEMM port this check over to make the behavior consistent?
@zhengwy888 zhengwy888 changed the title ChooseQuantizationParams is not checking for min/max validity ChooseQuantizationParams is not checking for min/max validity like Pytorch does Feb 10, 2023
@zhengwy888
Copy link
Author

cc @jspark1105 could you help ;-)

@jspark1105 jspark1105 mentioned this issue Feb 24, 2023
Open
jspark1105 added a commit to jspark1105/FBGEMM that referenced this issue Feb 24, 2023
@jspark1105 @facebook-github-bot
check min<=max in ChooseQuantizationParams
9ee9edc 
Summary: pytorch#1590

Differential Revision: D43383474

fbshipit-source-id: ff27b44b589f8dbde54f3a2c830d7d489f7a5138
@jspark1105 jspark1105 mentioned this issue Feb 25, 2023
Closed
jspark1105 added a commit to jspark1105/FBGEMM that referenced this issue Feb 26, 2023
@jspark1105 @facebook-github-bot
check min<=max in ChooseQuantizationParams (#95529)
e0ced99 
Summary:
X-link: pytorch/pytorch#95529

Pull Request resolved: pytorch#1612

pytorch#1590

Reviewed By: summerdengfb

Differential Revision: D43383474

fbshipit-source-id: 7b61eda2e80e5ca9c34cfe6b26f85adfd20ddc6e
jspark1105 added a commit to jspark1105/pytorch that referenced this issue Feb 26, 2023
@jspark1105 @facebook-github-bot
[fbgemm] check min<=max in ChooseQuantizationParams (pytorch#95529)
e088411 
Summary:
Pull Request resolved: pytorch#95529

X-link: pytorch/FBGEMM#1612

pytorch/FBGEMM#1590

Test Plan: CI

Reviewed By: summerdengfb

Differential Revision: D43383474

fbshipit-source-id: 337c82fa89b14b3633a2d61f233c98c1994bc71e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhengwy888