Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream 3 features for torch-trt: ms, VC, and optimisation level #1926

Closed
wants to merge 11 commits into from

Conversation

wu6u3tw
Copy link
Contributor

@wu6u3tw wu6u3tw commented May 17, 2023

Description

Upstream options:

  • max_aux_streams
  • version_compatible
  • optimization_level

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@wu6u3tw wu6u3tw changed the title Upstream Upstream 3 features for torch-trt: ms, VC, and optimisation level May 17, 2023
@wu6u3tw
Copy link
Contributor Author

wu6u3tw commented May 17, 2023

@nvpohanh for viz.

py/torch_tensorrt/fx/fx2trt.py Outdated Show resolved Hide resolved
py/torch_tensorrt/fx/fx2trt.py Outdated Show resolved Hide resolved
@narendasan
Copy link
Collaborator

@wu6u3tw can you mirror these changes for the fx_ts_compat frontend as well? Doesnt need to be the same PR but these changes seem useful for that as well

@wu6u3tw
Copy link
Contributor Author

wu6u3tw commented May 19, 2023

Yes, can do this on another PR.

@nvpohanh
Copy link
Contributor

Looks good to me now.

@wu6u3tw can you mirror these changes for the fx_ts_compat frontend as well? Doesnt need to be the same PR but these changes seem useful for that as well

@wu6u3tw Could you address @narendasan 's this comment? Thanks

@wu6u3tw
Copy link
Contributor Author

wu6u3tw commented May 19, 2023

Looks good to me now.

@wu6u3tw can you mirror these changes for the fx_ts_compat frontend as well? Doesnt need to be the same PR but these changes seem useful for that as well

@wu6u3tw Could you address @narendasan 's this comment? Thanks

Draft in prog. Will be PR out today.

@nvpohanh
Copy link
Contributor

@narendasan Anything blocking this PR from being merged?

@narendasan
Copy link
Collaborator

We need @frank-wei or someone on Meta's side to review this since this is an API change that might effect their stack

@nvpohanh
Copy link
Contributor

@frank-wei Could you review this? It has been 3 weeks since last update

@narendasan
Copy link
Collaborator

We are just going to close this since its in dynamo

@narendasan narendasan closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants