Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[Feature] Add support for truncate_long_and_double in Dynamo compile #1964

Closed
gs-olive opened this issue May 31, 2023 · 2 comments · Fixed by #1983
Closed

✨[Feature] Add support for truncate_long_and_double in Dynamo compile #1964

gs-olive opened this issue May 31, 2023 · 2 comments · Fixed by #1983
Assignees
Labels
feature request New feature or request Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path

Comments

@gs-olive
Copy link
Collaborator

Context

Certain models, including T5 (see #1864, #1740) require INT64 inputs to their embedding layers. 64-bit input types are not compatible with TRT Engines, however, thus a truncation mechanism is necessary to resolve this issue.

Feature Proposal

Add support for truncate_long_and_double in Dynamo compile, tracking data types and automatically casting to TRT-allowed types (and back) as necessary.

@gs-olive gs-olive added feature request New feature or request Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path labels May 31, 2023
@gs-olive gs-olive self-assigned this May 31, 2023
@narendasan
Copy link
Collaborator

@gs-olive We have this issue in review but the linked PR is closed, do we need to point this issue at a new PR?

@gs-olive
Copy link
Collaborator Author

I reordered the linked PRs (there were two, one of which had been closed), and now the issue should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path
Projects
None yet
2 participants