Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize converters for MaxPool1D and einsum #1985

Closed
gs-olive opened this issue Jun 5, 2023 · 5 comments
Closed

Centralize converters for MaxPool1D and einsum #1985

gs-olive opened this issue Jun 5, 2023 · 5 comments
Assignees
Labels
component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: fx

Comments

@gs-olive
Copy link
Collaborator

gs-olive commented Jun 5, 2023

@gs-olive gs-olive added component: fx component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 5, 2023
@gs-olive gs-olive self-assigned this Jun 5, 2023
@narendasan
Copy link
Collaborator

@gs-olive is this still blocked?

@gs-olive
Copy link
Collaborator Author

Pending discussion on the best location for converters such as those introduced in #1979, #1980. Is it preferable to move those converters to a central location even though the code that repairs the FX graph to add those ops is elsewhere?

@github-actions
Copy link

This issue has not seen activity for 90 days, Remove stale label or comment or this will be closed in 10 days

@gs-olive
Copy link
Collaborator Author

Addressed in #2317

@gs-olive
Copy link
Collaborator Author

Completed on main for maxpool. Einsum pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: fx
Projects
None yet
Development

No branches or pull requests

3 participants