Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move binary Docker manywheel and conda build workflows and scripts to pytorch/pytorch repo #1849

Open
atalman opened this issue Jun 1, 2024 · 0 comments · Fixed by pytorch/pytorch#128563
Assignees

Comments

@atalman
Copy link
Contributor

atalman commented Jun 1, 2024

I propose to:

  1. Move Conda Docker build workflows and scripts:
    https://github.com/pytorch/builder/blob/main/.github/workflows/build-conda-images.yml

  2. Move Docker images workflows are all required Docker recipes and associated scripts to pytorch/pytorch so that we can test the Docker builds and binary nightly builds in single PR:
    https://github.com/pytorch/builder/blob/main/.github/workflows/build-manywheel-images.yml
    https://github.com/pytorch/builder/blob/main/.github/workflows/build-libtorch-images.yml

This should facilitate doing cuda, cudnn updates, will require less pinning. Will increase visibility for these workflows

  1. Implement calculate which docker image to use based on sha - similar to CI workflows

cc @nWEIdia @tinglvv @ptrblck @malfet @juliagmt-google

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Prioritized
Development

Successfully merging a pull request may close this issue.

2 participants