Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clustering metrics #3290

Merged
merged 18 commits into from
Oct 21, 2024
Merged

Add clustering metrics #3290

merged 18 commits into from
Oct 21, 2024

Conversation

kzkadc
Copy link
Contributor

@kzkadc kzkadc commented Oct 12, 2024

Description: added metrics for evaluating clustering results implemented in scikit-learn:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added docs module: metrics Metrics module labels Oct 12, 2024
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @kzkadc !
I left few comments, let me know what you think

@kzkadc kzkadc mentioned this pull request Oct 13, 2024
3 tasks
@vfdev-5 vfdev-5 reopened this Oct 14, 2024
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 14, 2024

@kzkadc can you please also update this metric implementation https://github.com/pytorch/ignite/blob/master/ignite/metrics/precision_recall_curve.py according to the way we are now doing everywhere else (in a separate PR). Thanks!

@kzkadc
Copy link
Contributor Author

kzkadc commented Oct 14, 2024

@vfdev-5 could you recheck this PR again?

@vfdev-5 vfdev-5 reopened this Oct 14, 2024
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @kzkadc !
Let's see if CI is green to land it.

EDIT:
Unrelated failures with mypy:

+ mypy --config-file mypy.ini
ignite/metrics/fbeta.py:154: error: Unused "type: ignore" comment 
[unused-ignore]
                output_transform=(lambda x: x) if output_transform is None...
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ignite/metrics/fbeta.py:163: error: Unused "type: ignore" comment 
[unused-ignore]
                output_transform=(lambda x: x) if output_transform is None...
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ignite/handlers/time_profilers.py:420: error: Incompatible types in string
interpolation (expression has type "str", placeholder has type "int | float") 
[str-format]
            output_message = """
                             ^
Found 3 errors in 2 files (checked 151 source files)

@vfdev-5 vfdev-5 enabled auto-merge (squash) October 21, 2024 09:15
@vfdev-5 vfdev-5 merged commit 3c5e213 into pytorch:master Oct 21, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants