-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clustering metrics #3290
Add clustering metrics #3290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @kzkadc !
I left few comments, let me know what you think
@kzkadc can you please also update this metric implementation https://github.com/pytorch/ignite/blob/master/ignite/metrics/precision_recall_curve.py according to the way we are now doing everywhere else (in a separate PR). Thanks! |
@vfdev-5 could you recheck this PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @kzkadc !
Let's see if CI is green to land it.
EDIT:
Unrelated failures with mypy:
+ mypy --config-file mypy.ini
ignite/metrics/fbeta.py:154: error: Unused "type: ignore" comment
[unused-ignore]
output_transform=(lambda x: x) if output_transform is None...
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ignite/metrics/fbeta.py:163: error: Unused "type: ignore" comment
[unused-ignore]
output_transform=(lambda x: x) if output_transform is None...
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ignite/handlers/time_profilers.py:420: error: Incompatible types in string
interpolation (expression has type "str", placeholder has type "int | float")
[str-format]
output_message = """
^
Found 3 errors in 2 files (checked 151 source files)
Description: added metrics for evaluating clustering results implemented in scikit-learn:
Check list: