From 5476e36e2bd2dd4949a55f10ebd0606c6b5f3e28 Mon Sep 17 00:00:00 2001 From: BY571 Date: Tue, 9 Jul 2024 15:17:14 +0200 Subject: [PATCH] remove gamma from cost constructor --- torchrl/objectives/td3_bc.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/torchrl/objectives/td3_bc.py b/torchrl/objectives/td3_bc.py index 2b53464e174..c136fca5f3f 100644 --- a/torchrl/objectives/td3_bc.py +++ b/torchrl/objectives/td3_bc.py @@ -19,7 +19,6 @@ from torchrl.objectives.utils import ( _cache_values, - _GAMMA_LMBDA_DEPREC_ERROR, _reduce, _vmap_func, default_value_kwargs, @@ -238,7 +237,6 @@ def __init__( loss_function: str = "smooth_l1", delay_actor: bool = True, delay_qvalue: bool = True, - gamma: float = None, priority_key: str = None, separate_losses: bool = False, reduction: str = None, @@ -319,8 +317,6 @@ def __init__( high = high.to(device) self.register_buffer("max_action", high) self.register_buffer("min_action", low) - if gamma is not None: - raise TypeError(_GAMMA_LMBDA_DEPREC_ERROR) self._vmap_qvalue_network00 = _vmap_func( self.qvalue_network, randomness=self.vmap_randomness )