-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mergebot should reopen a PR when it's reverted #4692
Comments
Sounds simple, let me give it a try... |
|
It looks like restoring the deleted branch could be done if there is a need, i.e. pytorch/pytorch#112304 has a restore branch button at the bottom. Although I think it would need to try it out:
|
@huydhn branches are not auto-deleted, and only owner can restore a branch, so if PR is reverted, we should just try to revert as a first step |
And it works: malfet/deleteme#58 Cherry-picking PRs into torch |
Fixes pytorch/test-infra#4692 Test plan, see malfet/deleteme#58 (comment) / https://github.com/malfet/deleteme/actions/runs/6723011476 Pull Request resolved: pytorch#112614 Approved by: https://github.com/seemethere, https://github.com/ezyang ghstack dependencies: pytorch#112613
Fixes pytorch/test-infra#4692 Test plan, see malfet/deleteme#58 (comment) / https://github.com/malfet/deleteme/actions/runs/6723011476 Pull Request resolved: pytorch#112614 Approved by: https://github.com/seemethere, https://github.com/ezyang ghstack dependencies: pytorch#112613
Goal
When mergebot reverts a PR, reopen that PR as well. This'll make tracking reverted PRs easier for the authors
Caveat
It appears that sometimes github can't reopen regular PRs. It's been reported this can happen when the branch has been deleted or if it's been "merged" (potentially meaning this feature could only work for ghstack PRs), but this needs more investigation
The text was updated successfully, but these errors were encountered: