Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better max autotune discovery on pt2 dashboard #6175

Open
huydhn opened this issue Jan 15, 2025 · 1 comment
Open

Better max autotune discovery on pt2 dashboard #6175

huydhn opened this issue Jan 15, 2025 · 1 comment
Assignees
@yangw-dev

Comments

@huydhn
Copy link
Contributor

huydhn commented Jan 15, 2025

Max autotune benchmark run only once per week due to its cost, so it only shows up for some commits, i.e. https://hud.pytorch.org/benchmark/compilers?dashboard=torchinductor&startTime=Wed%2C%2001%20Jan%202025%2021%3A01%3A09%20GMT&stopTime=Wed%2C%2015%20Jan%202025%2021%3A01%3A09%20GMT&granularity=hour&mode=inference&dtype=bfloat16&deviceName=cuda%20(a100)&lBranch=main&lCommit=67f85ccdcf56894d653b4d37cd7651eefa0ddf8c&rBranch=main&rCommit=00df63f09f07546bacec734f37132edc58ccf574

It's pretty confusing because it's not clear which commit has the data.

cc @yangw-dev @zou3519
@huydhn huydhn mentioned this issue Jan 15, 2025
Open
@ZainRizvi ZainRizvi moved this to Cold Storage in PyTorch OSS Dev Infra Jan 21, 2025
@yangw-dev
Copy link
Contributor

yangw-dev commented Jan 22, 2025 •
edited
Loading

inductor_max_autotune:
The max_autotune dp is created weekly based on workflow:
https://github.com/pytorch/pytorch/blob/main/.github/workflows/inductor-perf-test-nightly.yml#L127
during the test , the value is generated based on the dashboard tag:
https://github.com/pytorch/pytorch/blob/main/.ci/pytorch/test.sh#L572

Related Pytorch Tutorial:
https://pytorch.org/tutorials/prototype/max_autotune_on_CPU_tutorial.html

@yangw-dev yangw-dev moved this from Cold Storage to In Progress in PyTorch OSS Dev Infra Jan 24, 2025
@yangw-dev yangw-dev self-assigned this Jan 24, 2025
@yangw-dev yangw-dev mentioned this issue Jan 29, 2025
Merged
yangw-dev added a commit that referenced this issue Jan 29, 2025
@yangw-dev
Maxoutissue (#6229)
83064c4 
# Add customized highlight option for BranchAndCommitPicker
Add customized highlight option for commit select
#6175

# Details
 - add filename as part of the query for Commit
 - filter and highlight commits based on the selected key word.
 - add info icon present highlight section's details

# Other Options (can be future)
define a dropdown to filter multiple keys to highlight

![image](https://github.com/user-attachments/assets/452211aa-df0b-420d-9847-ac80526ec887)



## Demo
Tooltip to indicate the highlight reason:

![image](https://github.com/user-attachments/assets/683d035c-cadf-4ca4-bc49-e0a78d69815a)

Gif for the action
![Jan-28-2025
14-33-14](https://github.com/user-attachments/assets/bdded1e1-7545-4a77-ac05-bb61b385946e)
@huydhn huydhn moved this from In Progress to Done in PyTorch OSS Dev Infra Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangw-dev yangw-dev

Labels
None yet
Projects
PyTorch OSS Dev Infra
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huydhn @yangw-dev