[BE][HUD] Introduce Label to GroupHudTable #5876
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
yangw-dev
changed the title
|
the floating feature for label guide can be disabled, can simply put it on left above the table. open for discussion |
| </Item> | ||
| ); | ||
| } | ||
| export default LabelGuide; |
There was a problem hiding this comment.
If you decide to keep the guide, I think it would be better to have things horizontally aligned? Like the all null ~ and the not exist ~ should both be on the same row. Idk how hard that would be tho
There was a problem hiding this comment.
IMO, I don't think we really need a legend table as most of the icons are easy to recognized. Even if there is one, I would prefer it to be collapsed by default. I think people will be confused about too much details like all null, not exist, neutral, warning only.
There was a problem hiding this comment.
Also, the label is already part of the job/group description when you hover the mouse over, so the legend table becomes redundant
There was a problem hiding this comment.
Sounds good! I can remove the label guide
There was a problem hiding this comment.
Can we still have a blinking icon for job that is in progress?
Also, as both in-progress and queue are represented by similar icon,I wonder if gray clock could indicate that jobs is queued, while yellow blinking one means that it's in progress...
There was a problem hiding this comment.
I don't recall ever having a blinking icon for in progress jobs?
There was a problem hiding this comment.
@malfet you mean like this lol? (Dark mode)
I changed it to rotating, let me know if this is better:
|
I think there's some unintended behavior on the pr/commit pages |
|
I wonder if there is a better icon for flaky tests, |
|
Also please test it out on dark mode to see if it looks ok, I'm pretty sure that some people are using that night-owl mode :P |
|
chatted offline with catherine, will make pending less stand out |
I see, I can fix that after this PR, meanwhile Catherine made good point that i may also have some feed back from treehugger about this icon changes, see what people think about this |
Overview
Add label guide and label for jobs in GroupHudTable
Background
Currently we use simple text ("Q","S","~" etc) to indicate the state of git jobs, it does not make important indicators to stand out, for instance, the success test should has less vision impact compared to other signals.
Details
OSS license
By following guide [Third_Party_in_OSS(https://www.internalfb.com/intern/wiki/Open_Source/Contribute_to_FB_OSS_Project/Third_Party_in_OSS/) All react-icon libs we use in this PR from react-icons are under approved license. One thing notice that, in REACT-ICONs the library
Weather Icons's licenseSIL OFL 1.1is not in the list Weather Icons SIL OFL 1.1Do NOT MERGE UNTIL
the dependency fix kicked in #5887 for package.json update