Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Commit

Permalink
Decouple the building of benchmarks and tests (#491)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #491

Tests and benchmarks targets are now de-coupled.
That means they can be built independently.
Shared functionality is moved to a common utility library.

Resolves facebookincubator/velox#1704

X-link: facebookincubator/velox#2439

Reviewed By: Yuhta

Differential Revision: D39484543

Pulled By: kgpai

fbshipit-source-id: 5ac888c81a6bbfbc5a1a1c4cfd41fa2c86199bc4
  • Loading branch information
leoluan2009 authored and facebook-github-bot committed Sep 15, 2022
1 parent 3bae0a3 commit 76c37d8
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions csrc/velox/functions/rec/tests/BucketizeTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@

#include <velox/common/base/VeloxException.h>
#include <velox/vector/SimpleVector.h>
#include <velox/vector/tests/VectorTestBase.h>
#include <velox/vector/tests/utils/VectorTestBase.h>

#include "pytorch/torcharrow/csrc/velox/functions/functions.h"
#include "velox/functions/prestosql/tests/FunctionBaseTest.h"
#include "velox/functions/prestosql/tests/utils/FunctionBaseTest.h"
#include "velox/parse/TypeResolver.h"

namespace facebook::velox {
Expand Down
4 changes: 2 additions & 2 deletions csrc/velox/functions/rec/tests/ComputeScoreTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@

#include <velox/common/base/VeloxException.h>
#include <velox/vector/SimpleVector.h>
#include <velox/vector/tests/VectorMaker.h>
#include <velox/vector/tests/utils/VectorMaker.h>

#include "pytorch/torcharrow/csrc/velox/functions/functions.h"
#include "velox/functions/prestosql/tests/FunctionBaseTest.h"
#include "velox/functions/prestosql/tests/utils/FunctionBaseTest.h"
#include "velox/parse/TypeResolver.h"

namespace facebook::velox {
Expand Down
4 changes: 2 additions & 2 deletions csrc/velox/functions/rec/tests/FirstXTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@

#include <velox/common/base/VeloxException.h>
#include <velox/vector/SimpleVector.h>
#include <velox/vector/tests/VectorTestBase.h>
#include <velox/vector/tests/utils/VectorTestBase.h>

#include "pytorch/torcharrow/csrc/velox/functions/functions.h"
#include "velox/functions/prestosql/tests/FunctionBaseTest.h"
#include "velox/functions/prestosql/tests/utils/FunctionBaseTest.h"
#include "velox/parse/TypeResolver.h"

namespace facebook::velox {
Expand Down
4 changes: 2 additions & 2 deletions csrc/velox/functions/rec/tests/SigridHashTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@

#include <velox/common/base/VeloxException.h>
#include <velox/vector/SimpleVector.h>
#include <velox/vector/tests/VectorMaker.h>
#include <velox/vector/tests/utils/VectorMaker.h>

#include "pytorch/torcharrow/csrc/velox/functions/functions.h"
#include "velox/functions/prestosql/tests/FunctionBaseTest.h"
#include "velox/functions/prestosql/tests/utils/FunctionBaseTest.h"
#include "velox/parse/TypeResolver.h"

namespace facebook::velox {
Expand Down
2 changes: 1 addition & 1 deletion csrc/velox/functions/tests/FunctionsTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include <velox/common/base/VeloxException.h>
#include <velox/vector/SimpleVector.h>
#include "pytorch/torcharrow/csrc/velox/functions/functions.h"
#include "velox/functions/prestosql/tests/FunctionBaseTest.h"
#include "velox/functions/prestosql/tests/utils/FunctionBaseTest.h"
#include "velox/parse/TypeResolver.h"

namespace facebook::velox {
Expand Down

0 comments on commit 76c37d8

Please sign in to comment.