Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to test each component #40

Closed
wanchaol opened this issue Feb 2, 2024 · 2 comments
Closed

Add tests to test each component #40

wanchaol opened this issue Feb 2, 2024 · 2 comments
Assignees
@wconstab
Labels
better_engineering Repo code quality improvements

Comments

@wanchaol
Copy link
Contributor

wanchaol commented Feb 2, 2024

The tentative tests we could add:

  1. test the llama debug model init and forward/backward works
  2. test checkpoint save/load works
  3. metrics logging test (metrics to be added)
@tianyu-l tianyu-l added the better_engineering Repo code quality improvements label May 3, 2024
@tianyu-l
Copy link
Contributor

TODO: test correctness of checkpointable data loading in #279

@tianyu-l
Copy link
Contributor

@wconstab is going to help set up an example multi-gpu unit test. We can add more functionality unit test following the example.

@tianyu-l tianyu-l removed this from the torchtrain infrastructure building milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wconstab wconstab

Labels
better_engineering Repo code quality improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wconstab @wanchaol @tianyu-l