Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize use of Pathlib throughout the codebase #434

Closed
RdoubleA opened this issue Feb 29, 2024 · 0 comments
Closed

Standardize use of Pathlib throughout the codebase #434

RdoubleA opened this issue Feb 29, 2024 · 0 comments
Assignees
@RdoubleA
Labels
best practice Things we should be doing but aren't

Comments

@RdoubleA
Copy link
Contributor

For handling directory paths, we have a mix of using os and Pathlib across the code base. os leads to some clunky code, an example is:

ROOT_DIR: str = os.path.join(os.path.abspath(__file__), "../../../configs")

We should default to Pathlib and update all os.path calls. See this thread for more context.

cc @joecummings, @ebsmothers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RdoubleA RdoubleA

Labels
best practice Things we should be doing but aren't
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RdoubleA @kartikayk