Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - miissed onnxruntime dependency #3027

Closed
labintsev opened this issue Sep 3, 2024 · 2 comments · Fixed by #3033
Closed

[BUG] - miissed onnxruntime dependency #3027

labintsev opened this issue Sep 3, 2024 · 2 comments · Fixed by #3033
Labels
bug onnx Issues relating to ONNX

Comments

@labintsev
Copy link
Contributor

labintsev commented Sep 3, 2024

Link

https://pytorch.org/tutorials/beginner/onnx/intro_onnx.html#dependencies

Bug

The ONNX exporter depends on extra Python packages: onnx, onnxscript and onnxruntime.
But in tutorial there are only onnx and onnxscript.
May be in some versions onnxruntime installing implicitly, but in my environment it does not.

I think we need explicit list of dependencies in text and in code
pip install onnx onnxscript onnxruntime

Environment

Platform: windows
Cuda: No
python: 3.11
Pytorch: 2.3.0+cpu
onnxscript: 0.1.0.dev20240903
onnxruntime: 1.19.0

cc @xadupre

@labintsev labintsev added the bug label Sep 3, 2024
@svekars svekars added the onnx Issues relating to ONNX label Sep 3, 2024
@svekars
Copy link
Contributor

svekars commented Sep 4, 2024

It does look like you need to run pip install onnx onnxscript onnxruntime. My guess is that this was for some reason omitted by the author (@thiagocrepaldi) because for the Sphinx build we install through requirements.txt. @labintsev do you want to submit a PR with this change?

@labintsev
Copy link
Contributor Author

Yes, when I get this tutorial, it was a little issue for me

@labintsev labintsev mentioned this issue Sep 4, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug onnx Issues relating to ONNX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants